fix: Enforce strict domain validation and scope rules in human_approval_manager.py #569
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UtkarshMishra-Microsoft
requested review from
Avijit-Microsoft,
Fr4nc3,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft and
marktayl1
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Summary:
Implemented CRITICAL DOMAIN CHECK to enforce team-specific task validation:
Retail teams (CustomerDataAgent/OrderDataAgent) now hard-reject HR-related requests.
HR teams (HRHelperAgent) now handle only HR/employee requests.
Marketing teams (ProductAgent/MarketingAgent) handle only product/marketing requests.
Integrated ProxyAgent to deliver polite rejections when requests fall outside domain scope.
Enforced hard rule to never reference or suggest external sources or services.
Resolved:
BUG 23366: Bug - Asked for 5-day Seattle weather forecast, was given a rich answer but from 3 months ago?
BUG 23863: Bug - Wrong task for wrong team still works pretty well; maybe it should not?
Ensured zero follow-up steps or clarifications are added for out-of-scope requests.
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information